JENKINS-68822 added support for removing all builds with LogRotator #9405

madisparn · 2024-06-20T15:35:26Z

See JENKINS-68822.

Testing done

Verified configuration in UI
Checked that old configuration is loaded from disk
Run the unit tests

Proposed changelog entries

Allow all builds to be removed by the build discarder.

Proposed upgrade guidelines

N/A

Submitter checklist

Give feedback

The Jira issue, if it exists, is well-described.
The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
There is automated testing or an explanation as to why this change has no tests.
New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
For dependency updates, there are links to external changelogs and, if possible, full differentials.
For new APIs and extension points, there is a link to at least one consumer.
Options

Before the changes are marked as ready-for-merge:

Maintainer checklist

Give feedback

There are at least two (2) approvals for the pull request and no outstanding requests for change.
Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
Proper changelog labels are set so that the changelog can be generated automatically.
If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).
Options

welcome · 2024-06-20T15:35:30Z

Yay, your first pull request towards Jenkins core was created successfully! Thank you so much!

A contributor will provide feedback soon. Meanwhile, you can join the chats and community forums to connect with other Jenkins users, developers, and maintainers.

timja · 2024-07-11T07:19:12Z

core/src/main/java/hudson/tasks/LogRotator.java

+        Run lsb = removeLastSuccessfulBuild ? null : job.getLastSuccessfulBuild();
+        Run lstb = removeLastStableBuild ? null : job.getLastStableBuild();


hmm I think this logic may not be 100% correct.

I have selected "Remove last stable build" - Yes

and then I have a stable build (success) and 2 failures.

My stable build never gets removed because I have set Remove last successful build - no.

The UI seems to be a bit too tied to the implementation.

At a minimum I think if remove last stable build is selected as yes and the last successful build is a stable build then it should be removed.

I wonder if we need both UI options, would it be enough to just add the stable option?

Or do you have any ideas on how it could be simpler?

Indeed, having a single UI setting is simpler.

timja · 2024-07-11T10:49:06Z

core/src/main/resources/hudson/tasks/LogRotator/config.jelly

@@ -41,5 +41,9 @@ THE SOFTWARE.
             description="${%if not empty, only up to this number of builds have their artifacts retained}" field="artifactNumToKeepStr">
      <f:number clazz="positive-number" min="1" step="1" />
    </f:entry>
+    <f:entry title="${%Remove last stable and successful builds}"


what about these? The label seems too tied to the developer writing code instead of from a user perspective imo.

Suggested change

<f:entry title="${%Remove last stable and successful builds}"

<f:entry title="${%Remove last build}"

or

Suggested change

<f:entry title="${%Remove last stable and successful builds}"

<f:entry title="${%Remove last successful build}"

successful is still a bit confusing as 'unstable' is successful from my reading of the code.

Picked the shorter option, more clear to me as developer :)

core/src/main/java/hudson/tasks/LogRotator.java

timja

Thanks!

daniel-beck · 2024-07-12T06:55:50Z

Weak -0.5 as this does not appear to be a common use case and is better off being done in a plugin.

NotMyFault · 2024-08-13T05:35:24Z

/label ready-for-merge

This PR is now ready for merge. We will merge it after ~24 hours if there is no negative feedback.
Please see the merge process documentation for more information about the merge process.
Thanks!

welcome · 2024-08-21T05:46:44Z

Congratulations on getting your very first Jenkins core pull request merged 🎉🥳

This is a fantastic achievement, and we're thrilled to have you as part of our community! Thank you for your valuable input, and we look forward to seeing more of your contributions in the future!

We would like to invite you to join the community chats and forums to meet other Jenkins contributors 😊
Don't forget to check out the participation page to learn more about how to contribute to Jenkins.

timja added the rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted label Jun 21, 2024

timja requested a review from a team June 21, 2024 08:44

timja reviewed Jul 11, 2024

View reviewed changes

madisparn force-pushed the master branch from 3bc4ff1 to 29e4767 Compare July 11, 2024 08:22

madisparn requested a review from timja July 11, 2024 08:24

timja reviewed Jul 11, 2024

View reviewed changes

JENKINS-68822 added support for removing all builds with LogRotator

2803f6b

madisparn force-pushed the master branch from 0f39a55 to 2803f6b Compare July 11, 2024 13:00

madisparn requested a review from timja July 11, 2024 17:10

timja reviewed Jul 11, 2024

View reviewed changes

core/src/main/java/hudson/tasks/LogRotator.java Outdated Show resolved Hide resolved

Update core/src/main/java/hudson/tasks/LogRotator.java

96bc078

timja approved these changes Jul 11, 2024

View reviewed changes

timja requested a review from NotMyFault July 11, 2024 17:51

NotMyFault approved these changes Aug 11, 2024

View reviewed changes

comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Aug 13, 2024

NotMyFault merged commit b064be0 into jenkinsci:master Aug 21, 2024
16 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

JENKINS-68822 added support for removing all builds with LogRotator #9405

JENKINS-68822 added support for removing all builds with LogRotator #9405

madisparn commented Jun 20, 2024 •

edited by MarkEWaite

Loading

Submitter checklist

Maintainer checklist

welcome bot commented Jun 20, 2024

timja Jul 11, 2024

madisparn Jul 11, 2024

timja Jul 11, 2024

madisparn Jul 11, 2024

timja left a comment

daniel-beck commented Jul 12, 2024

NotMyFault commented Aug 13, 2024

welcome bot commented Aug 21, 2024

		Run lsb = removeLastSuccessfulBuild ? null : job.getLastSuccessfulBuild();
		Run lstb = removeLastStableBuild ? null : job.getLastStableBuild();

	<f:entry title="${%Remove last stable and successful builds}"
	<f:entry title="${%Remove last build}"

	<f:entry title="${%Remove last stable and successful builds}"
	<f:entry title="${%Remove last successful build}"

JENKINS-68822 added support for removing all builds with LogRotator #9405

JENKINS-68822 added support for removing all builds with LogRotator #9405

Conversation

madisparn commented Jun 20, 2024 • edited by MarkEWaite Loading

Testing done

Proposed changelog entries

Proposed upgrade guidelines

Submitter checklist

Maintainer checklist

welcome bot commented Jun 20, 2024

timja Jul 11, 2024

Choose a reason for hiding this comment

madisparn Jul 11, 2024

Choose a reason for hiding this comment

timja Jul 11, 2024

Choose a reason for hiding this comment

madisparn Jul 11, 2024

Choose a reason for hiding this comment

timja left a comment

Choose a reason for hiding this comment

daniel-beck commented Jul 12, 2024

NotMyFault commented Aug 13, 2024

welcome bot commented Aug 21, 2024

madisparn commented Jun 20, 2024 •

edited by MarkEWaite

Loading